bug: 업로드 안되는 버그 및 업로드 화면 개선 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
chopmozzi
approved these changes
Dec 10, 2023
| @@ -159,9 +161,10 @@ class Provider: ProviderType { | |||
| sessionTaskDelegate: URLSessionTaskDelegate? = nil, | |||
| delegateQueue: OperationQueue? = nil) async throws -> Data { | |||
| guard let url = URL(string: url) else { throw NetworkError.components } | |||
| guard let mimeType = UTType(filenameExtension: fromFile.pathExtension)?.preferredMIMEType else { throw NetworkError.unknown } | |||
There was a problem hiding this comment.
이거 프로필 사진 업로드에도 사용해야겠어요. 감사합니다.
Comment on lines
+56
to
+63
| UIView.animate(withDuration: 0.3, delay: 0.5, options: .curveEaseOut, animations: { | ||
| toastLabel.alpha = 1.0 | ||
| }, completion: { _ in | ||
| toastLabel.removeFromSuperview() | ||
| UIView.animate(withDuration: 1.0, delay: 1.0, options: .curveEaseOut, animations: { | ||
| toastLabel.alpha = 0.0 | ||
| }, completion: { _ in | ||
| toastLabel.removeFromSuperview() | ||
| }) |
loinsir
reviewed
Dec 10, 2023
| @@ -155,7 +173,12 @@ extension EditVideoViewController: EditVideoDisplayLogic { | |||
| loopStart: .zero, | |||
| duration: viewModel.duration) | |||
| loopingPlayerView.play() | |||
| loopingPlayerView.player?.isMuted = soundButton.isSelected | |||
loinsir
approved these changes
Dec 10, 2023
@chopmozzi 주소 길어질 경우 글자크기가 줄어들도록 변경해놓았습니다 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
해당 pr에서 작업한 내역을 적어주세요.
RPReplay_Final1702147015.MP4
RPReplay_Final1702147182.MP4
Linked Issue
close #268